Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Pages Fixed #8242

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Issue with Pages Fixed #8242

merged 4 commits into from
Oct 26, 2023

Conversation

KNaveenraj-ladybird
Copy link
Contributor

Issues Fixed

  1. Login -> agent -> tools-> knowledge base -> now accessible
  2. Check if able to create,edit ,delete,view for category , article , pages ,comments ,settings
  3. Support center -> guest -> now able to comment on articles
  4. Page -> field would be displayed only if a page is created with public and published for guest or client and for agent/admin -> published

@KNaveenraj-ladybird KNaveenraj-ladybird added Requires Code Review PD: Demo Approved Demo of the feature / bug fix was approved by Product team labels Oct 9, 2023
@KNaveenraj-ladybird KNaveenraj-ladybird added this to the v2.0.3 milestone Oct 9, 2023
@KNaveenraj-ladybird KNaveenraj-ladybird self-assigned this Oct 9, 2023
@pull-request-size pull-request-size bot added the size/XL Issue will take 2-3 weeks to complete label Oct 9, 2023
@KNaveenraj-ladybird KNaveenraj-ladybird removed the size/XL Issue will take 2-3 weeks to complete label Oct 9, 2023
@KNaveenraj-ladybird KNaveenraj-ladybird linked an issue Oct 9, 2023 that may be closed by this pull request
Issue with pages #697
Closed
@KNaveenraj-ladybird KNaveenraj-ladybird changed the title page_fix Issue with Pages Fixed Oct 9, 2023
@pull-request-size pull-request-size bot added the size/XL Issue will take 2-3 weeks to complete label Oct 9, 2023
RafficMohammed
RafficMohammed previously approved these changes Oct 13, 2023
View reviewed changes
@Sabaric12 Sabaric12 added the QA: Round 1 Testing In Progress First round of testing is in progress label Oct 13, 2023
@Sabaric12
Copy link

Round 1:Test summary
Tested this PR with the existing instance the mentioned issues are working fine now
Total time in days: 3 hours
Total issues: 0
Minor - 0
Major - 0
Critical - 0
No of times PR was sent for Functionality correction:0
PR breaks existing functionality: No
Note:-
One existing issue I created a separate issue
#8248

@Sabaric12 Sabaric12 added QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed and removed QA: Round 1 Testing In Progress First round of testing is in progress labels Oct 14, 2023
@AbishekChinnaraju AbishekChinnaraju added the QA: Round 2 Testing In Progress Second round of testing in progress label Oct 14, 2023
@AbishekChinnaraju
Copy link

Second Round Test summary:
Tested this PR with the existing server instance.
Total time in days: 1 hours
Total issues: 0
Minor - 0
Major - 0
Critical - 0
No of times PR was sent for Functionality correction:0
PR breaks existing functionality: No
Note:-
The mentioned issues are working fine now.
One existing issue I created a separate issue #8248

@AbishekChinnaraju AbishekChinnaraju added QA: Functionality Approved Functionality tested and approved by QA team and removed Requires Functionality Review QA: Round 2 Testing In Progress Second round of testing in progress QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed labels Oct 14, 2023
@RafficMohammed RafficMohammed merged commit 3237bf8 into development Oct 26, 2023
2 of 3 checks passed
@KNaveenraj-ladybird
Copy link
Contributor Author

KNaveenraj-ladybird commented Oct 26, 2023 via email

@KNaveenraj-ladybird
Copy link
Contributor Author

KNaveenraj-ladybird commented Oct 26, 2023 via email

@KNaveenraj-ladybird KNaveenraj-ladybird mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbishekChinnaraju AbishekChinnaraju AbishekChinnaraju approved these changes

@Sabaric12 Sabaric12 Sabaric12 approved these changes

@RafficMohammed RafficMohammed RafficMohammed left review comments

Assignees

@KNaveenraj-ladybird KNaveenraj-ladybird

Labels
Code Approved PD: Demo Approved Demo of the feature / bug fix was approved by Product team QA: Functionality Approved Functionality tested and approved by QA team size/XL Issue will take 2-3 weeks to complete
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.

Issue with pages
6 participants
@KNaveenraj-ladybird @Sabaric12 @AbishekChinnaraju @RafficMohammed @StyleCIBot @bhanu2217